Skip to content

RUM-9461 Remove Feature Baggage #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 3 commits into from
May 21, 2025
Merged

RUM-9461 Remove Feature Baggage #2304

dd-mergequeue merged 3 commits into from
May 21, 2025

Conversation

@maxep
Copy link
Member

@maxep maxep commented May 20, 2025 •
edited
Loading

What and why?

Remove FeatureBaggage, AnyEncoder, and AnyDecoder following migration to strongly-typed FeatureMessage.payload and AdditionalContext:

Resolves:

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines (internal) and run make api-surface)

@maxep maxep force-pushed the maxep/RUM-9461/remove-feature-baggage branch from 7fc001d to edc5faf Compare May 20, 2025 08:34
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 20, 2025 •
edited
Loading

Datadog Report

Branch report: maxep/RUM-9461/remove-feature-baggage
Commit report: 9324063
Test service: dd-sdk-ios

✅ 0 Failed, 2235 Passed, 1631 Skipped, 3m 7.91s Total duration (1m 41.31s time saved)

@maxep maxep marked this pull request as ready for review May 20, 2025 09:05
@maxep maxep requested review from a team as code owners May 20, 2025 09:05
@maxep maxep force-pushed the maxep/RUM-9461/remove-feature-baggage branch from af7a932 to 9324063 Compare May 20, 2025 13:33
simaoseica-dd
simaoseica-dd approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@simaoseica-dd simaoseica-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@maxep
Copy link
Member Author

maxep commented May 21, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 21, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-21 08:36:42 UTC ℹ️ Start processing command /merge

2025-05-21 08:36:47 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 1h (p90).

2025-05-21 09:18:31 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 4e28d23 into develop May 21, 2025
15 checks passed
@dd-mergequeue dd-mergequeue bot deleted the maxep/RUM-9461/remove-feature-baggage branch May 21, 2025 09:18
This was referenced May 21, 2025
Merged
Merged
@simaoseica-dd simaoseica-dd mentioned this pull request May 26, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simaoseica-dd simaoseica-dd simaoseica-dd approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxep @simaoseica-dd